Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cypress to v12 #2276

Closed
wants to merge 24 commits into from
Closed

chore: upgrade cypress to v12 #2276

wants to merge 24 commits into from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Mar 30, 2023

Key features

  1. update Cypress to latest version 12
  2. adjust files and configuration

Description

Upgrade Cypress dependencies and tests to run with latest Cypress version 12.


TODO

  • bump @dhis2/cli-utils-cypress when this PR is merged

Known issues

  • some tests are failing, not expected

Screenshots

Screenshot 2023-03-30 at 11 43 00

@edoardo edoardo requested a review from jenniferarnesen March 30, 2023 09:50
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 30, 2023

🚀 Deployed on https://pr-2276--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 30, 2023 09:55 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 31, 2023 14:43 Inactive
@edoardo edoardo force-pushed the chore/cypress-upgrade branch from b3e39ac to e7a68d8 Compare April 12, 2023 14:05
@dhis2-bot dhis2-bot temporarily deployed to netlify April 12, 2023 14:09 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify April 13, 2023 11:25 Inactive
package.json Outdated
"cy:open-stub": "cypress_dhis2_api_stub_mode=STUB d2-utils-cypress open --appStart 'yarn cypress:start'",
"cy:run-stub": "cypress_dhis2_api_stub_mode=STUB d2-utils-cypress run --tags '@nonmutating' --appStart 'yarn cypress:start' --record",
"cy:capture": "cypress_dhis2_api_stub_mode=CAPTURE yarn d2-utils-cypress run --appStart 'yarn cypress:start'"
"cypress:open:live": "yarn cypress open --env networkMode=live",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the network shim isn't in use, maybe we should simplify all this and just have
cy:run and cy.open like with our other repos. There would also be changes in the support/e2e.js file for this.

@jenniferarnesen jenniferarnesen changed the base branch from master to dev June 6, 2023 09:40
jenniferarnesen and others added 11 commits June 7, 2023 14:23
The verify workflow should run on tags, so that a corresponding branch is created
in the d2-ci repository

Do not run the release step on PRs, but do allow it for pushes

yarn cypress install sometimes fails. Turns out it isn't necessary anyway
since the cypress-io gh action takes care of installing cypress.
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jen Jones Arnesen <[email protected]>
* chore: nightly failing to set up cypress (#2378)

The verify workflow should run on tags, so that a corresponding branch is created
in the d2-ci repository

Do not run the release step on PRs, but do allow it for pushes

yarn cypress install sometimes fails. Turns out it isn't necessary anyway
since the cypress-io gh action takes care of installing cypress.

* fix(translations): sync translations from transifex (dev)

Automatically merged.

* docs: move docs to app (#2384)

* chore(release): cut 100.0.1 [skip release]

## [100.0.1](v100.0.0...v100.0.1) (2023-06-12)

### Bug Fixes

* **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6))

* chore(deps): bump @dhis2/analytics from 25.1.10 to 25.1.15

Bumps [@dhis2/analytics](https://github.com/dhis2/analytics) from 25.1.10 to 25.1.15.
- [Release notes](https://github.com/dhis2/analytics/releases)
- [Changelog](https://github.com/dhis2/analytics/blob/master/CHANGELOG.md)
- [Commits](dhis2/analytics@v25.1.10...v25.1.15)

---
updated-dependencies:
- dependency-name: "@dhis2/analytics"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jen Jones Arnesen <[email protected]>
Co-authored-by: @dhis2-bot <[email protected]>
Co-authored-by: Jan Henrik Øverland <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: nightly failing to set up cypress (#2378)

The verify workflow should run on tags, so that a corresponding branch is created
in the d2-ci repository

Do not run the release step on PRs, but do allow it for pushes

yarn cypress install sometimes fails. Turns out it isn't necessary anyway
since the cypress-io gh action takes care of installing cypress.

* fix(translations): sync translations from transifex (dev)

Automatically merged.

* docs: move docs to app (#2384)

* chore(release): cut 100.0.1 [skip release]

## [100.0.1](v100.0.0...v100.0.1) (2023-06-12)

### Bug Fixes

* **translations:** sync translations from transifex (dev) ([5b0b3b6](5b0b3b6))

* chore(deps): bump @dhis2/ui from 8.13.6 to 8.13.11

Bumps [@dhis2/ui](https://github.com/dhis2/ui/tree/HEAD/collections/ui) from 8.13.6 to 8.13.11.
- [Release notes](https://github.com/dhis2/ui/releases)
- [Changelog](https://github.com/dhis2/ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dhis2/ui/commits/v8.13.11/collections/ui)

---
updated-dependencies:
- dependency-name: "@dhis2/ui"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Jen Jones Arnesen <[email protected]>
Co-authored-by: @dhis2-bot <[email protected]>
Co-authored-by: Jan Henrik Øverland <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This is temporary during summer 2023 when there is very little frontend or backend activity
@edoardo edoardo force-pushed the chore/cypress-upgrade branch from 639b8cf to c1fe8cf Compare July 6, 2023 10:10
@edoardo edoardo force-pushed the chore/cypress-upgrade branch from c1fe8cf to dd960be Compare July 6, 2023 10:10
@dhis2-bot dhis2-bot temporarily deployed to netlify July 6, 2023 10:14 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 6, 2023 10:51 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify July 6, 2023 13:41 Inactive
@HendrikThePendric HendrikThePendric changed the title chore: Cypress 12 upgrade chore: upgrade cypress to v12 Jul 6, 2023
@HendrikThePendric HendrikThePendric marked this pull request as ready for review July 6, 2023 15:10
@HendrikThePendric HendrikThePendric added the on hold Do not review or merge yet label Jul 6, 2023
@HendrikThePendric
Copy link
Contributor

I've taken the PR out of draft and added the "on hold" label, because the e2e tests don't run for draft PRs.

@dhis2-bot dhis2-bot temporarily deployed to netlify July 6, 2023 15:45 Inactive
@cypress
Copy link

cypress bot commented Jul 6, 2023

8 failed and 3 flaky tests on run #3784 ↗︎

8 49 0 0 Flakiness 3

Details:

Merge d728f76 into afac010...
Project: dashboards-app Commit: 08e01dcbe6 ℹ️
Status: Failed Duration: 13:24 💡
Started: Jul 6, 2023 3:50 PM Ended: Jul 6, 2023 4:03 PM
Failed  edit/edit_dashboard.feature • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Creating, editing and deleting dashboard > I toggle show description Output Screenshots Video
Failed  view/view_dashboard.feature • 1 failed test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Viewing dashboards > Maps with tracked entities show layer names in legend Output Screenshots Video
Failed  view/dashboard_filter.feature • 3 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Dashboard filter > I add a Period filter Output Screenshots Video
Dashboard filter > I add a Organisation unit filter Output Screenshots Video
Dashboard filter > I add a Facility Type filter Output Screenshots Video
Failed  view/view_errors.feature • 3 failed tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Errors while in view mode > Item visualization fails when filter applied [DHIS2-11303] Output Screenshots Video
Errors while in view mode > Item visualization fails when filter applied and viewed as table [DHIS2-11303] Output Screenshots Video
Errors while in view mode > Item visualization fails when filter applied and viewed as table then viewed as chart [DHIS2-11303] Output Screenshots Video
Flakiness  view_dashboard.feature • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Viewing dashboards > I search for a dashboard Output Screenshots Video
Flakiness  item_context_menu.feature • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Item context menu > Text item does not have a context menu Output Screenshots
Flakiness  view_errors.feature • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Errors while in view mode > I delete the dashboard that was created for this test suite Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jenniferarnesen jenniferarnesen force-pushed the dev branch 2 times, most recently from b919316 to 7f603d6 Compare March 19, 2024 14:10
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 07:54
@edoardo edoardo removed the on hold Do not review or merge yet label Aug 2, 2024
@edoardo
Copy link
Member Author

edoardo commented Aug 2, 2024

Superseded by #3040

@edoardo edoardo closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants